<html>
<head><meta charset="utf-8"><title>Duplicate start date nightly pulls + tests · t-compiler/cargo-bisect-rustc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/index.html">t-compiler/cargo-bisect-rustc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate.20start.20date.20nightly.20pulls.20.2B.20tests.html">Duplicate start date nightly pulls + tests</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="188026372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate%20start%20date%20nightly%20pulls%20%2B%20tests/near/188026372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate.20start.20date.20nightly.20pulls.20.2B.20tests.html#188026372">(Feb 12 2020 at 16:26)</a>:</h4>
<p>When I run bisect-rustc with a start and end date range, I am seeing two pulls of the start nightly to confirm that the regression is not reproduced at the beginning of the date range <em>when there is no regression at the start date</em>: </p>
<div class="codehilite"><pre><span></span>checking nightly-2019-07-01
std for x86_64-unknown-linux-gnu: 61.49 MB / 61.49 MB [=========================================] 100.00 % 12.52 MB/s
uninstalling nightly-2019-07-01
verifying the start of the range does not reproduce the regression
std for x86_64-unknown-linux-gnu: 61.49 MB / 61.49 MB [=========================================] 100.00 % 13.48 MB/s
uninstalling nightly-2019-07-01
tested nightly-2019-07-01, got No
confirmed the start of the range does not reproduce the regression

[ ... ]
</pre></div>


<p>I think that this is duplicating the build as well.</p>
<p>It looks like the first run is in <a href="https://github.com/rust-lang/cargo-bisect-rustc/blob/8f1132148f76d7e6e4176d1d49f472e865439a48/src/main.rs#L1067-L1079" target="_blank" title="https://github.com/rust-lang/cargo-bisect-rustc/blob/8f1132148f76d7e6e4176d1d49f472e865439a48/src/main.rs#L1067-L1079">this block</a> of <code>bisect_nightlies</code> and the second is in <a href="https://github.com/rust-lang/cargo-bisect-rustc/blob/8f1132148f76d7e6e4176d1d49f472e865439a48/src/least_satisfying.rs#L22-L27" target="_blank" title="https://github.com/rust-lang/cargo-bisect-rustc/blob/8f1132148f76d7e6e4176d1d49f472e865439a48/src/least_satisfying.rs#L22-L27">this block</a> of <code>least_satisfying</code>.</p>
<p>The start range check appears to be required in <code>least_satisfying</code> for calls from <code>bisect_ci</code> and <code>bisect_ci_between</code>.  And it appears that the start range check is also required in the <code>bisect_nightly</code> loop to support the logic there.  Thoughts about the addition of a boolean <code>skip_start_check</code> parameter on <code>least_satisfying</code> to prevent <a href="https://github.com/rust-lang/cargo-bisect-rustc/blob/8f1132148f76d7e6e4176d1d49f472e865439a48/src/least_satisfying.rs#L21-L27" target="_blank" title="https://github.com/rust-lang/cargo-bisect-rustc/blob/8f1132148f76d7e6e4176d1d49f472e865439a48/src/least_satisfying.rs#L21-L27">this block</a> from being executed on the nightly bisect runs only?</p>



<a name="189189132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate%20start%20date%20nightly%20pulls%20%2B%20tests/near/189189132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate.20start.20date.20nightly.20pulls.20.2B.20tests.html#189189132">(Feb 27 2020 at 05:55)</a>:</h4>
<p>Fix for this issue submitted in <a href="https://github.com/rust-lang/cargo-bisect-rustc/pull/62" target="_blank" title="https://github.com/rust-lang/cargo-bisect-rustc/pull/62">https://github.com/rust-lang/cargo-bisect-rustc/pull/62</a></p>



<a name="190021095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate%20start%20date%20nightly%20pulls%20%2B%20tests/near/190021095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/217417-t-compiler/cargo-bisect-rustc/topic/Duplicate.20start.20date.20nightly.20pulls.20.2B.20tests.html#190021095">(Mar 08 2020 at 17:24)</a>:</h4>
<p>I refactored <a href="https://github.com/rust-lang/cargo-bisect-rustc/pull/62" target="_blank" title="https://github.com/rust-lang/cargo-bisect-rustc/pull/62">https://github.com/rust-lang/cargo-bisect-rustc/pull/62</a> based on Santiago's review.  This now addresses duplicated code in the nightly and CI Toolchain testing and fixes the duplicated download/install/test of the start range nightly check when <code>--start</code> is specified on the CL.  I also cleaned up the std stream reporting during execution so that it is easier to understand what nightly / commit is being tested and the result at that nightly/commit.   Let me know what you think.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>